Deprecation on implicit bool conversions to true for values other than 1 - #8565

I fixed the failing iterator tests so they are not affected by this deprecation, and I created the RFC which contains more details: https://wiki.php.net/rfc/stricter_implicit_boolean_coercions

A deprecation notice appeared on Travis in run-tests.php, where "failed" or "success" were given to a bool parameter (which should have been string parameter instead), as if trying to highlight coercion problems ;-) I changed it to a string parameter. The mail_qa_team function now posts the status with "success" and "failed" (instead of always having status 1) as it probably should, although that change could be done separately from this RFC of course.

I'm expecting OpCache to need to have changes made as it now needs to bail out off certain optimizations.

I started to look at Opcache and if I need to change anything there, but nothing stuck out so far (but remember, I am super new to the php-src codebase). Are there tests for Opcache/JIT for something like this, or would it make sense to add more tests specifically for something like this to opcache/jit?

I managed to fix all other existing tests with the exception of the AppVeyor build: there are just two failures left, one failure is in scalar_basic.phpt where PHP_INT_MAX shows up as -1 in the deprecation notice not satisfying the pattern %d, and in scalar_return_basic_64bit.phpt where 9223372036854775807 shows up as -1 instead of 9223372036854775807. On the other testing platforms this works as expected (and also locally), and me not knowing the reason for this is probably just showing my lacking C skills, but reporting the correct integer that lead to the notice (and not -1) would be helpful. Any hints on how to best resolve this would be appreciated.

Compile with CFLAGS="-DPROFITABILITY_CHECKS=0" and the run: make test TEST_PHP_ARGS="-q -j22 -d opcache.jit=function -d opcache.enable=1 -d opcache.enable_cli=1 -d opcache.file_update_protection=0 -d opcache.jit_buffer_size=1M" TESTS="Zend ext/opcache" this should test the JIT and likely find OpCache issues

Thanks! I did both and all the tests passed.

RFC has been declined