Repository navigation
Report undefined footnote references to the broken link callback - #1187
Open
akasakariko wants to merge 1 commit into
Open
akasakariko wants to merge 1 commit into
akasakariko wants to merge 1 commit into
Conversation
GFM footnote references without a matching definition are rendered as literal text, but the parser never reported them through the broken link callback. Invoke the callback for these references and document that the returned URL and title are ignored since footnote references are not links
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1072
GFM footnote references without a matching definition are rendered as literal text, but they were never reported through the broken link callback. This invokes the callback for those references so callers such as
-Rand rustdoc can detect them[^label], andLinkType::ShortcutParserCallbacks::handle_broken_linkAdded a regression test covering one undefined and one defined footnote reference
Verification:
cargo test --workspacecargo test --features=serdecargo test --features=simd,gen-testscargo test --no-default-features --features hashbrowncargo check --benchescargo fmt --checkprintf 'See [^missing]\n' | cargo run -- -R --enable-footnotesnow exits non-zero and reports the broken reference