Repository navigation
Modernise main.css - #93
Conversation
zware
left a comment
There was a problem hiding this comment.
I can't offer much in the way of technical review of this, but the screenshots look nice :). Would love to have a dark mode added, but that certainly doesn't need to block this PR if it's more effort than you want to go to for right now. I've seen Hugo and Petr do nice things with buildbot's CSS if you want to ping one of them for a technical and/or a11y review.
|
Are you using the Python home template or the sample one? I fixed the Python home template yesterday to show the tables so maybe you’re missing that commit (it’s not included on this branch)? |
|
Something weird, with the test data I see "Latest Results (rss)" and "Latest Significant Results" tables on the home page, with this PR they are gone? |
|
(I have no idea why my comment shows up before yours, Matti.) After the branch update, here's what it looks like for me: 
|
A dark theme is very much needed, but I'd like to get this in as it also largely refactors the structure of the site and of the I think I'll annoy Hugo/Petr for an accessibility review then, as contrast will be more of an issue. |
|
Ah, nice. No further comments from me, all looks good. |
Some screen shots of the new pages:
This is a start, it certainly ain't finished. These changes also (mostly) apply cleanly to
speed.pypy.org, @mattip what do you think, I'd appreciate your review.In follow ups I plan to improve the home page, flesh it out a little and maybe add some geo-mean graph. I also plan to find a high-resolution logo to use.