Skip to content

gh-74876: Skip weakref pickling tests in test_xpickle for Python < 3.16 - #160082

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:gh-74876-xpickle-skip
Oct 21, 2026
Merged

serhiy-storchaka merged 1 commit into
python:mainfrom
serhiy-storchaka:gh-74876-xpickle-skip

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Oct 21, 2026 •

Copy link
Copy Markdown
Member

Weak reference pickling is only supported since Python 3.16, so the new tests fail in test_xpickle when run against older Python versions.

🤖 Generated with Claude Code

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix.

@serhiy-storchaka
serhiy-storchaka merged commit bb55157 into python:main Oct 21, 2026
60 checks passed
@serhiy-storchaka
serhiy-storchaka deleted the gh-74876-xpickle-skip branch October 21, 2026 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants