Repository navigation
fix: lazy id object - #1541
fix: lazy id object#1541oux wants to merge 1 commit into
Conversation
to align lazy id object and non-lazy id object and then make ObjectDeleteMixin works with lazy object Signed-off-by: Sebastien MICHEL <[email protected]>
There was a problem hiding this comment.
Hi @oux, sorry for the very late response. This was part of a much larger URL-encoding issue and I was reluctant to merge a small, specific solution.
I believe we have now solved the underlying issue in a more general way that solves it for all endpoints and ensures a string is only ever URL-encoded once: #1819
However, I see you've added some tests here which may be useful. If you remove the mixins.py change, rebase, and add only the tests, I'd be really happy to merge this as a test PR. Please let me know if you'd like to continue working on this PR. :)
| try: | ||
| branch.delete() | ||
| except gitlab.exceptions.GitlabDeleteError as e: | ||
| print(f"Project already deleted: {e}") |
There was a problem hiding this comment.
| print(f"Project already deleted: {e}") | |
| print(f"Branch already deleted: {e}") |
|
This Pull Request (PR) was marked stale because it has been open 90 days with no activity. Please remove the stale label or comment on this PR. Otherwise, it will be closed in 15 days. |
|
This PR was closed because it has been marked stale for 15 days with no activity. If this PR is still valid, please re-open. |
to align lazy id object and non-lazy id object and then make
ObjectDeleteMixin works with lazy object
Fixes #1494
Signed-off-by: Sebastien MICHEL [email protected]