Repository navigation
fix(cli): expose the required job artifact path - #3455
Open
UmutAlisoglu wants to merge 1 commit into
Open
UmutAlisoglu wants to merge 1 commit into
UmutAlisoglu wants to merge 1 commit into
Conversation
Signed-off-by: Umut Alisoglu <[email protected]>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3455 +/- ##
==========================================
+ Coverage 95.78% 95.94% +0.16%
==========================================
Files 100 100
Lines 6172 6172
==========================================
+ Hits 5912 5922 +10
+ Misses 260 250 -10
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The
project-job artifactaction has a requiredpathargument in the Python API, but its CLI registration never exposes it. The help omits--path, passing it is rejected, and omitting it leaves the action without a required argument.Register
pathas required and add an example beside the existing ZIP-download command:gitlab project-job artifact --project-id 1 --id 10 --path reports/result.xml > result.xmlFixes #1926. The Python API and archive-download action are unchanged.
Documentation and testing
Four new tests fail before the change and pass afterward. They cover required-argument validation and mocked CLI dispatch/HTTP downloads for simple, nested, and space-containing paths, preserving binary response bytes.
On Windows / Python 3.13.7:
-n -W --keep-going) passes.twine checkpasses for both.The tox package-check wrapper cannot parse this checkout path containing spaces, so its equivalent build/twine commands were run directly. Docker-based tests against a live GitLab instance were not run; HTTP calls in the new tests use responses mocks.
AI assistance was used for implementation and tests. Signed off.