Repository navigation
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 48-to-dicts-empty #640 +/- ##
====================================================
Coverage ? 98.65%
====================================================
Files ? 105
Lines ? 29280
Branches ? 3447
====================================================
Hits ? 28885
Misses ? 252
Partials ? 143 🚀 New features to boost your workflow:
|
eriknw
force-pushed
the
47-ss-export-full-message
branch
from
October 19, 2026 07:55
a3d3a06 to
9f1f0ef
Compare
Member
Author
|
Hooray better error messages! LGTM |
eriknw
force-pushed
the
47-ss-export-full-message
branch
2 times, most recently
from
October 21, 2026 04:14
410a715 to
b5615ad
Compare
eriknw
force-pushed
the
47-ss-export-full-message
branch
2 times, most recently
from
October 28, 2026 04:29
2668c6b to
ff376e4
Compare
eriknw
force-pushed
the
47-ss-export-full-message
branch
from
October 28, 2026 13:21
ff376e4 to
e3ff3e3
Compare
Vector.ss.export("full"), Matrix.ss.export("fullr") and "fullc", and
the same formats through ss.unpack, on an object with missing entries
raised InvalidValue with an empty message: SuiteSparse refuses with
GrB_INVALID_VALUE and sets no error string, so there was nothing to
show. The object itself was left intact.
Check the entry count first and raise InvalidValue (the same type as
before) with the count and the format:
Matrix with 1 of 4 entries is not full, so it cannot export to
format 'fullr'
eriknw
force-pushed
the
47-ss-export-full-message
branch
from
October 29, 2026 02:01
e3ff3e3 to
aca2f1f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ss.exportandss.unpackto "full", "fullr" or "fullc" on an object withmissing entries raised InvalidValue with an empty message, because SuiteSparse
sets no error string there (the object was left intact). It now raises
InvalidValue (same type) as "Matrix with 1 of 4 entries is not full, so it
cannot export to format 'fullr'". Tests: export and unpack, Vector and both
Matrix orders.