Repository navigation
Conversation
Author
|
FYI I tried to run the automatic formatting target but it reformatted lots of existing files in the repository, so I did not include that here. |
1 of 3 tasks
In some LDAP implementations attribute ordering is relevant. Allow for modifications which consider the order of attributes by implementing an optional "strict_order_attr_types" parameter which takes a list of attributes to exempt from the transformation to a set. Signed-off-by: Georg Pfuetzenreuter <[email protected]>
spaceone
reviewed
Oct 18, 2026
Comment on lines
+95
to
+97
| normalize = bytes.lower if attrtype_lower in case_ignore_attr_types_set else lambda v: v | ||
| collection = list if attrtype_lower in strict_order_attr_types_set else set | ||
| replace_attr_value = collection(map(normalize, old_value)) != collection(map(normalize, new_value)) |
Contributor
There was a problem hiding this comment.
I allowed myself to rebase your branch @tacerus - and placed a commit on top of it which simplifies the logic a bit.
What I don't really like is that clients need to maintain a list of attributes which are affected by this.
My personal preference would be to use that behavior always - and require the clients to do it the other way round - if they want to eliminate some replace-operations they should not reorder (use sets instead).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some LDAP implementations attribute ordering is relevant. Allow for modifications which consider the order of attributes by implementing an optional "strict_order_attr_types" parameter which takes a list of attributes to exempt from the transformation to a set.