Repository navigation
Conversation
Contributor
Author
|
Feel free to reject. I will adjust all callers then, that only empy strings are passed instead. |
Contributor
|
You'd have to change it to Mapping to let the concrete implementations pass typecheck, but including None in the passed dict sounds strange so I think I'd prefer you passed |
spaceone
force-pushed
the
refactor/sasl-authzid
branch
2 times, most recently
from
October 19, 2026 10:55
79353e4 to
eb43064
Compare
Update the SASL callback value type annotation to also accept bytes and None, reflecting the values supported by the existing callback implementation. SASL callback values such as `authzid` and `authcid` may be None, in which case the callback falls back to the SASL-provided default value or an empty string. Additionally, byte strings are valid callback values and should be accepted without requiring conversion to str. Issue python-ldap#368
spaceone
force-pushed
the
refactor/sasl-authzid
branch
from
October 19, 2026 21:58
eb43064 to
0523b3f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it's allowed to pass values e.g.
authzid/authcidas None, which will default to the SASL default value or an empty string:Issue #368