Repository navigation
Conversation
Use explicit UTF-8 decoding for DNs instead of pyasn1 OctetString string conversion, which will decode as ISO8859-1. This is a leftover from the Python 3 migration as there was always str() wrappping, which was a bytes-string in Python 2 but since Python 3 that was implicitly decoded by pyasn. Issue: #647 Issue: #647
spaceone
force-pushed
the
fix/647-control-str-bytes-confusion
branch
from
October 17, 2026 14:28
64a3f49 to
63b5ff5
Compare
droideck
approved these changes
Oct 21, 2026
droideck
left a comment
Member
There was a problem hiding this comment.
LGTM. But I think it'll be nice for @mistotebe to check too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use explicit UTF-8 decoding for DNs instead of pyasn1 OctetString string conversion, which will decode as ISO8859-1.
This is a leftover from the Python 3 migration as there was always str() wrappping, which was a bytes-string in Python 2 but since Python 3 that was implicitly decoded by pyasn.
Issue: #647
Issue: #647