Repository navigation
Conversation
incompatible with Python 3 syntax. Python 2 support was removed.
```pycon
>>> import ldap
>>> import ldap.async
File "<python-input-1>", line 1
import ldap.async
^^^^^
SyntaxError: invalid syntax
```
droideck
requested changes
Oct 21, 2026
droideck
left a comment
Member
There was a problem hiding this comment.
I'd keep ldap.async through 3.x and remove it in 4.0. Although the documented deprecation window has passed, this still removes an existing import path, and the compatibility shim costs little to retain. So I'd make the 4.0 removal explicit in the docs.
Contributor
Author
|
I would be fine with it if I see that it could actually be used. But it can't → |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
incompatible with Python 3 syntax. Python 2 support was removed.