Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #689. Addresses the cell-level content-control part of #1489, not its separate cached field-text problem.
Word can wrap a complete table cell in
w:sdt/w:sdtContent. Current traversal skips that cell, shifting extracted values into the wrong columns and sometimes makingtable.cell()select a cell from the following row.tc_lstunchanged.Validation
Linux, Python 3.12.14, lxml 6.1.1:
pytest -q: 1,631 passed, including all 22 new cases. Unchanged master: 1,609 passed; the new regression file fails against unchanged master.behave --format progress --stop --tags=-wip: 67 features, 650 scenarios, 1,856 steps passed on both the final candidate and unchanged master.Pyright 1.1.401 reports no diagnostics in the changed files, but exits nonzero with one unused-ignore diagnostic in its bundled
_typeshed/_type_checker_internals.pyi. The same diagnostic occurs on unchanged master; it has not been suppressed.Scope
This does not add content-control authoring, cached
fldSimpletext extraction, or fix existing aggregate indexing for rows with omitted grid cells. No Word GUI/rendering or full multi-Python tox matrix was run.AI-assisted implementation and review; the test results above were actually executed.