Repository navigation
Quantity with units returns True for __eq__ with plain numpy array #146
Description
Consider this:
In [10]: 2.1*pq.m == np.array(2.1)
Out[10]: True
I would have expected it to return True only if the Quantity instance was dimensionless.
What do others think?
EDIT:
since the numbers (arrays) cannot be added to each other, I think it really should be an error:
>>> 3*pq.m + 3
ValueError ...
Activity
Change comparison of Quantity (to fix python-quantitiesgh-146)
Change comparison of Quantity (to fix python-quantitiesgh-146)
apdavison commentedon Jan 29, 2018
Similarly,
I think this behaviour should be changed, but it would be a major change, potentially affecting a lot of downstream libraries, so an extended period with deprecation warnings would be needed.
Please can other people chime in with their opinion?