Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pq.ediff1dcurrently strips the units ofto_beginandto_endwithout converting their magnitudes:This returns
[1000., 2., 3.] mV; the first value should be1 mV. Rescale quantity-valued boundary differences to the input units before passing their magnitudes to NumPy. Incompatible dimensions now raiseValueError. Numeric boundaries retain their existing interpretation, and NumPy's casting checks apply after conversion.Tests cover both boundaries, scalar and array values, flattened inputs, incompatible dimensions and integer casting. The full suite and README doctests pass on Python 3.10/NumPy 1.24 and Python 3.12/NumPy 2.4 and 2.5. Mypy passes on NumPy 1.24 and 2.4; the existing NumPy 2.5 typing error is unchanged and covered by #277. Advisory lint results are unchanged.
In a chunk-differencing check on four channels of PhysioNet's S001R01 EEG recording, converting boundary differences from microvolts to millivolts removes 96 wrong values across 72 cases. All 144 same-unit or numeric-boundary controls remain identical.