Skip to content

Cleanup typecode switch - IEnumerable and object cases #428

Closed

Description

Activity

  1. filmor commented on Mar 23, 2017

    @filmor
    Member

    Reopen with description, please.

  2. den-run-ai commented on Mar 23, 2017

    @den-run-ai
    ContributorAuthor

    2 options suggested by @vmuriart:

    1. Delete that section of code IEnumerable altogether or
    2. Delete typecode.Object.

    The remaining typecodes are Empty, DBNull, Decimal and DateTime and i don't think any of those should be converted to PyList.
    Also, I can't think of a situation in which the default branch of the switch would be hit because we have Typecode.Object defined; It would always be called instead of the default. This example is probably closer to how it should be written.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions