You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Cleanup typecode switch - IEnumerable and object cases #428
Delete that section of code IEnumerable altogether or
Delete typecode.Object.
The remaining typecodes are Empty, DBNull, Decimal and DateTime and i don't think any of those should be converted to PyList.
Also, I can't think of a situation in which the default branch of the switch would be hit because we have Typecode.Object defined; It would always be called instead of the default. This example is probably closer to how it should be written.
Activity
filmor commentedon Mar 23, 2017
Reopen with description, please.
den-run-ai commentedon Mar 23, 2017
2 options suggested by @vmuriart:
IEnumerablealtogether orThe remaining typecodes are Empty, DBNull, Decimal and DateTime and i don't think any of those should be converted to PyList.
Also, I can't think of a situation in which the default branch of the switch would be hit because we have Typecode.Object defined; It would always be called instead of the default. This example is probably closer to how it should be written.