Repository navigation
Updating Hashing function to Murmur3 - #7
Merged
Merged
Conversation
patricioe
approved these changes
Dec 16, 2016
patricioe
left a comment
Contributor
There was a problem hiding this comment.
@adilaijaz have a look.
Let's not merge until all other SDKs have their branches ready too.
Contributor
|
Pato, where the seed gets used depends on the hashing algorithm. In murmur,
it gets used in the beginning.
…On Dec 29, 2016 9:06 PM, "Patricio Echague" ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In src/main/java/io/split/client/utils/MurmurHash3.java
<#7 (review)>
:
> + | ((buf[offset + 3] & 0xffL) << 24)
+ | ((buf[offset + 2] & 0xffL) << 16)
+ | ((buf[offset + 1] & 0xffL) << 8)
+ | ((buf[offset] & 0xffL)); // no shift needed
+ }
+
+
+ /**
+ * Returns the MurmurHash3_x86_32 hash.
+ */
+ public static int murmurhash3_x86_32(byte[] data, int offset, int len, int seed) {
+
+ final int c1 = 0xcc9e2d51;
+ final int c2 = 0x1b873593;
+
+ int h1 = seed;
@adilaijaz <https://github.com/adilaijaz> the seed should be used at the
very end correct?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#7 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAnR1azOwGB1vyM_2yUYyeyGvIKmacJzks5rM_aSgaJpZM4LOwPo>
.
|
Murmur3 unsigned
patricioe
reviewed
Mar 13, 2017
| * @author adil | ||
| */ | ||
| public class Splitter { | ||
| private static final int ALGO_MURMUR = 1; |
Contributor
There was a problem hiding this comment.
murmur is actually #2. see ticket: https://splitio.atlassian.net/browse/SPLIT-2578
Contributor
There was a problem hiding this comment.
yeah confirmed. This is not correct.
Contributor
Author
|
LGTM |
bot2-harness
pushed a commit
that referenced
this pull request
Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.