Repository navigation
[Cloudberry] Add PQS, TLP and DQP test oracles - #1370
Merged
Merged
Conversation
roseduan
force-pushed
the
cloudberry-oracles
branch
from
October 16, 2026 03:29
d66a010 to
f556cc4
Compare
Add the oracles PQS, HAVING, AGGREGATE, DISTINCT, GROUP_BY, QUERY_PARTITIONING and DQP. DQP runs each query under GPORCA and the PostgreSQL-based planner, and with join, aggregation and motion methods disabled, and checks that all plans return the same rows. The CI job now also runs TestCloudberryTLP, TestCloudberryPQS and TestCloudberryDQP. GPORCA falls back to the PostgreSQL-based planner for queries with ONLY or whole-row references, so the new oracles and the NoREC and WHERE oracles no longer generate them. Fix two places where CloudberryProvider ignored --cloudberry-oracle: it now skips databases with empty tables when an oracle requires rows, and enables generateOnlyKnown for PQS. Work around the Cloudberry bugs found by these oracles: - apache/cloudberry#2134: expect the errors of a PAX table broken by REINDEX DATABASE CONCURRENTLY - apache/cloudberry#2135: do not generate CREATE STATISTICS, which can crash the coordinator - apache/cloudberry#2137: do not generate SET wal_compression, which crashes the mirrors Also expect the error raised when a redistributed table has an inheritance child with an incompatible UNIQUE index.
roseduan
force-pushed
the
cloudberry-oracles
branch
from
October 16, 2026 07:00
f556cc4 to
044e355
Compare
Contributor
Author
|
I add some necessary test suites for Apache Cloudberry, please review it when you are free. Thanks a lot! |
mrigger
approved these changes
Oct 20, 2026
| assertEquals(0, | ||
| Main.executeMain(new String[] { "--random-seed", "0", "--timeout-seconds", TestConfig.SECONDS, | ||
| "--num-threads", "4", "--num-queries", TestConfig.NUM_QUERIES, "--username", "gpadmin", | ||
| "cloudberry", "--connection-url", "postgresql://localhost:7000/test", "--test-collations", |
Contributor
There was a problem hiding this comment.
Regarding the port, perhaps we could subsequently encode this as a constant somewhere? Not sure, but I remember we also had a common option for this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the oracles PQS, HAVING, AGGREGATE, DISTINCT, GROUP_BY, QUERY_PARTITIONING and DQP. DQP runs each query under GPORCA and the PostgreSQL-based planner, and with join, aggregation and motion methods disabled, and checks that all plans return the same rows. The CI job now also runs TestCloudberryTLP, TestCloudberryPQS and TestCloudberryDQP.
GPORCA falls back to the PostgreSQL-based planner for queries with ONLY or whole-row references, so the new oracles and the NoREC and WHERE oracles no longer generate them.
Fix two places where CloudberryProvider ignored --cloudberry-oracle: it now skips databases with empty tables when an oracle requires rows, and enables generateOnlyKnown for PQS.