Repository navigation
Conversation
|
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey! I maintain
eloqnt/cli, a linter for translation files, and have been running it against public repos to see whether their catalogs carry errors.For teable, it found 85 errors:
inconsistent-args: 47superfluous-key: 38For example, the German lockout message translated the argument name itself:
teable/packages/common-i18n/src/locales/de/auth.json
Line 37 in 5ef2238
Original:
teable/packages/common-i18n/src/locales/en/auth.json
Line 37 in 5ef2238
Due to this, i18next fails to format such strings.
This PR adds a
lint:i18nscript to@teable/common-i18n, runs it in the linting workflow, and fixes the errors. Where a translation had drifted from the current English beyond a placeholder repair, I regenerated it witheloqnt translate. The linter itself runs locally, with no account or hosted service.Up to you if you're interested in adopting
eloqnt/cli, but you might want the translation fixes in this PR to fix runtime errors and more.