Repository navigation
Conversation
The create record dialog did not provide ModalContext, so user, select and other editor popovers were portaled to document.body. The modal dialog blocks wheel scroll outside its content, so long option lists (e.g. the user picker) could not be scrolled with the mouse wheel. Provide the dialog content as the portal container, as the expand record modal already does. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the Add record dialog, long option lists in field editors cannot be scrolled with the mouse wheel. The user picker (user field) is the easiest way to see it: with more users than fit in the list, the wheel does nothing. Typing in the search box or dragging the scrollbar still works.
Cause
CreateRecordModaldoes not provideModalContext, so editors that portal their popover intouseModalRefElement()(user, select, …) fall back todocument.body. The modalDialogblocks wheel scroll outside its content (react-remove-scroll), so the popover list outside the dialog does not scroll. The expand recordModalalready providesModalContext, which is why the same editors scroll fine there.Fix
Provide the dialog content element as
ModalContextinCreateRecordModal, the same wayexpand-record/Modal.tsxdoes. Most of the diff is re-indentation from wrapping the children in the provider.Checked
[role=dialog],scrollTopstays0after wheel scroll.eslintandtsc --noEmitforpackages/sdkpass.🤖 Generated with Claude Code