fix(css): keep the space before an SVG data: URL the minifier rewrites - #22880

⚙️ Run configuration

• Source mode: Auto
• Repository: webpack/webpack
• Branch: main
• File: .coderabbit.yaml
• Commit: 706e46f
• Layers: Repository YAML
• Review profile: CHILL
• Plan: Advanced
• Run ID: 8c279ea0-515f-4815-9383-f865f251e96c

📥 Commits

Reviewing files that changed from the base of the PR and between 97a5485 and c279d5b.

📒 Files selected for processing: 1

• lib/css/syntax-printer.js

🚧 Files skipped from review as they are similar to previous changes: 1

• lib/css/syntax-printer.js

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

The CSS printer now preserves the url( opener when it defers SVG data URL output. A unit test checks that minification retains spaces before two SVG data URLs in background declarations.

Changes: SVG data URL spacing

Layer / File(s)	Summary
Deferred URL output and regression coverage lib/css/syntax-printer.js, test/unitCases/css/printer.unittest.js, .changeset/060-css-minify-svg-url-space.md	Both URL printing paths pass the url( opener to _deferDataUrl. The deferred output includes the opener and closing ), while the stored build result excludes the wrapper. The test checks optimized SVG data URLs and preserved spaces. The changeset records a patch release.

Suggested labels: area: css

The change preserves spacing around the tested SVG data URLs, with no identified issue requiring a fix before merge.

Pre-merge checks: 3 · 1

Failed checks: 1 inconclusive

Check name	Status	Explanation	Resolution
Title check		The title uses the required Conventional Commit form and accurately describes the CSS SVG data URL spacing fix. The branch prefix is not provided, so the required type-to-branch-prefix match cannot be…	Provide the branch name or branch prefix to verify that it matches the fix type.

Passed checks: 3 passed

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check		Issue #22877 requires the CSS minifier to preserve the separator before SVG data: URLs and to include automated coverage. lib/css/syntax-printer.js now defers the url( wrapper with the marker an…
Out of Scope Changes check		The source change fixes the linked SVG data: URL spacing issue. The unit test verifies the fix. The changeset documents the same behavior. No unrelated change is shown in the reviewed scope.

Full details: Linked Issues check

Explanation

Issue #22877 requires the CSS minifier to preserve the separator before SVG data: URLs and to include automated coverage. lib/css/syntax-printer.js now defers the url( wrapper with the marker and restores the closing ). test/unitCases/css/printer.unittest.js covers two SVG data: URLs and verifies the preserved spaces and optimized SVG output.

Full details: Title check

Explanation

The title uses the required Conventional Commit form and accurately describes the CSS SVG data URL spacing fix. The branch prefix is not provided, so the required type-to-branch-prefix match cannot be verified.

Resolution

Provide the branch name or branch prefix to verify that it matches the fix type.

• X
• Mastodon
• Reddit
• LinkedIn

⚠️ 111 benchmarks are dominated by system calls

System calls cannot be simulated consistently and are left out of the measure. The reported value understates the real cost. Switch to the Walltime instrument to measure them.

Learn more about system calls

See affected benchmarks

⚠️ Base and head ran on different runner types

Some benchmarks with significant performance changes were compared across different runner types, so the changes might not come from the code. Run base and head on the same runner type, or use CodSpeed Macro Runners for more stable results.

Learn more about Macro Runners

Open the report in CodSpeed to investigate

ℹ️ 46 benchmarks have no flamegraph

The flamegraph wasn't generated: most of the time was spent in runtime internals, which would leave nothing useful to analyze.

See affected benchmarks