Repository navigation
Conversation
Signed-off-by: Revinand <[email protected]>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #7091 +/- ##
==========================================
+ Coverage 50.97% 50.99% +0.01%
==========================================
Files 455 455
Lines 56994 56994
Branches 8321 8321
==========================================
+ Hits 29055 29062 +7
+ Misses 25954 25946 -8
- Partials 1985 1986 +1
... and 2 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
An on-demand feature view cannot have schema fields with a
descriptionortags.feast applyfails on such a view withSpecifiedFeaturesNotPresentError._feature_exists_in_inferredchecksspecified_feature in inferred_features, which usesField.__eq__and compares the description, tags and vector settings. The inferred fields carry only a name and a type, and a scalar field with a description never matches. The check now compares the name and the type.With only that change,
feast applysucceeds, but the view read back from the registry has an empty description._parse_features_from_protobuilds eachFieldfrom the name, the value type and the vector settings instead of callingField.from_proto, whichFeatureViewandStreamFeatureViewuse. Besides the description and tags, it loses the inner types of nested outputs:OnDemandFeatureView.from_proto(odfv.to_proto())on masterStruct({a: Int64})Struct({_value: String})Array(Array(Int64))Array(Array(String))Array(Struct({a: Int64}))Array(Struct({_value: String}))_parse_features_from_protonow returnsField.from_proto(feature)for each feature.To reproduce, add
description="val plus one"to aFieldin the schema of an@on_demand_feature_viewwith aRequestSource, in a repo with the local provider and the SQLite online store, and runfeast apply. On master it stops after "Applying changes for project repro" withSpecifiedFeaturesNotPresentError. With this change it prints "Created on demand feature view plus_one", andstore.get_on_demand_feature_view("plus_one").features[0].descriptionis'val plus one'.Which issue(s) this PR fixes:
Fixes #3617. The stale bot closed it in 2025 without a fix. It reports the first half; the registry round-trip has no issue.
Checks
git commit -s)Testing Strategy
Misc
test_schema_field_metadata_survives_inference_and_proto_round_tripintests/unit/test_on_demand_feature_view.pychecks that the description and tags surviveinfer_features, that a proto round-trip returns the original fields, including Struct and nested Array types, and that a wrong type still raisesSpecifiedFeaturesNotPresentError. It fails on master.test_on_demand_feature_view.pyandtest_on_demand_python_transformation.pypass, and ruff is clean.ODFVs that are already registered with Struct or nested outputs now load with their real inner types instead of
_value: String.