Repository navigation
feat: add a minimal GraphQL client - #2967
Merged
Merged
Conversation
nejch
force-pushed
the
feat/minimal-graphql-client
branch
2 times, most recently
from
September 3, 2024 11:59
381a2bb to
c78419c
Compare
max-wittig
approved these changes
Sep 3, 2024
nejch
commented
Sep 3, 2024
nejch
force-pushed
the
feat/minimal-graphql-client
branch
from
September 3, 2024 14:10
c78419c to
7d583ab
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2967 +/- ##
==========================================
+ Coverage 96.53% 96.55% +0.02%
==========================================
Files 94 95 +1
Lines 5997 6040 +43
==========================================
+ Hits 5789 5832 +43
Misses 208 208
Flags with carried forward coverage won't be shown. Click here to find out more.
|
nejch
force-pushed
the
feat/minimal-graphql-client
branch
2 times, most recently
from
September 3, 2024 15:48
43cf128 to
4a6cb45
Compare
nejch
marked this pull request as ready for review
September 3, 2024 16:07
nejch
commented
Sep 3, 2024
JohnVillalovos
left a comment
Member
There was a problem hiding this comment.
Overall, looks good to me.
Thanks!
I left some minor comments.
nejch
force-pushed
the
feat/minimal-graphql-client
branch
from
September 3, 2024 18:47
4a6cb45 to
3cb40d8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #1357
Adds a minimal client without any bells and whistles, to keep the diff small and then we can bring in more common handling from the REST client.
Documentation and testing
Please consider whether this PR needs documentation and tests. This is not required, but highly appreciated: