Skip to content

refactor(client): move retry logic into utility - #2972

Merged
max-wittig merged 1 commit into
mainfrom
feat/graphql-retry
Sep 10, 2024
Merged

max-wittig merged 1 commit into
mainfrom
feat/graphql-retry

Conversation

@nejch

@nejch nejch commented Sep 10, 2024

Copy link
Copy Markdown
Member

Needed for #1357

Follow-up to #2967

@codecov

codecov Bot commented Sep 10, 2024 •

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.59%. Comparing base (fe5e608) to head (a19de7d).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2972      +/-   ##
==========================================
+ Coverage   96.55%   96.59%   +0.04%     
==========================================
  Files          95       95              
  Lines        6040     6056      +16     
==========================================
+ Hits         5832     5850      +18     
+ Misses        208      206       -2     
Flag Coverage Δ
api_func_v4 82.66% <64.28%> (+0.09%) ⬆️
cli_func_v4 83.19% <42.85%> (-0.04%) ⬇️
unit 88.62% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
gitlab/client.py 98.61% <100.00%> (+0.32%) ⬆️
gitlab/utils.py 98.54% <100.00%> (+0.56%) ⬆️

@nejch
nejch force-pushed the feat/graphql-retry branch from 281a42e to a19de7d Compare September 10, 2024 13:48
@nejch
nejch marked this pull request as ready for review September 10, 2024 13:53
@nejch

nejch commented Sep 10, 2024

Copy link
Copy Markdown
Member Author

@max-wittig this should help reuse the retry logic for the GraphQL client a bit more.

@max-wittig
max-wittig merged commit 3235c48 into main Sep 10, 2024
@max-wittig
max-wittig deleted the feat/graphql-retry branch September 10, 2024 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants